iverase commented on PR #15732: URL: https://github.com/apache/lucene/pull/15732#issuecomment-3935736878
> mergeFlatVectors and mergeVectorIndex, each of which would iterate over all the fields? I thought about that but decided against it because I did not what to give specific names to the phases (maybe in a future there is no flat vectors but something else?). Another benefit of this approach is that it is easy to share information between the two phases (e.g. FieldInfo). But I don't feel strong about this, if we think is better to expose it via two methods, it can be done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
