rmuir commented on PR #15763: URL: https://github.com/apache/lucene/pull/15763#issuecomment-3947497383
Yeah I think its only in one place, in Regexp. We use the heavy duty complement() as a way "complement" a character set `[^a-z]`-style logic. It is a contained case because we only pass it a flat minimal DFA containing the ranges. We pass it Integer.MAX_VALUE for the det limit, and there's a code comment. But this is just laziness: complement of this character set can be a simple private method there, that just loops through the start-end ranges and returns a character set from the "gaps". Most other usages are only in tests and could be moved to AutomatonTestUtil? Oh, and of course `Operations.minus()` uses this. `Operations.minus()` should definitely be deprecated too and is only used by tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
