iverase commented on code in PR #15989:
URL: https://github.com/apache/lucene/pull/15989#discussion_r3153648260
##########
lucene/core/src/java/org/apache/lucene/search/SkipBlockRangeIterator.java:
##########
@@ -66,7 +78,32 @@ public int advance(int target) throws IOException {
// Find the next matching block (could be the current block)
skipper.advance(minValue, maxValue);
- return doc = Math.max(target, skipper.minDocID(0));
+ int nextDoc = Math.max(target, skipper.minDocID(0));
Review Comment:
Looking at this method above, it can return documents that do not contain
values for sparse data.
We only care that the docId is inside a matching block and it is up to the
caller to check the block match and act accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
