benwtrent commented on code in PR #16002:
URL: https://github.com/apache/lucene/pull/16002#discussion_r3170847963
##########
lucene/core/src/java/org/apache/lucene/search/MaxScoreBulkScorer.java:
##########
@@ -148,17 +148,22 @@ private void scoreInnerWindow(
if (filter != null) {
scoreInnerWindowWithFilter(collector, acceptDocs, max, filter);
} else {
- DisiWrapper top = essentialQueue.top();
- DisiWrapper top2 = essentialQueue.top2();
- if (top2 == null) {
- scoreInnerWindowSingleEssentialClause(collector, acceptDocs, max);
- } else if (top2.doc - INNER_WINDOW_SIZE / 2 >= top.doc) {
- // The first half of the window would match a single clause. Let's
collect this single
- // clause until the next doc ID of the next clause.
- scoreInnerWindowSingleEssentialClause(collector, acceptDocs,
Math.min(max, top2.doc));
- } else {
- scoreInnerWindowMultipleEssentialClauses(collector, acceptDocs, max);
- }
+ scoreInnerWindowWithoutFilter(collector, acceptDocs, max);
Review Comment:
why all these unnecessary changes?
The idea is to improve `scoreInnerWindowWithFilter` right? We are focused on
bulk scoring doc end run number of docs?
Please, we need way more than a JMH benchmark. We need to ensure correctness
& please benchmark with lucene util to see the performance on a realistic
dataset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
