shubhamvishu commented on PR #15982: URL: https://github.com/apache/lucene/pull/15982#issuecomment-4360268066
I'd prefer if instead on (normal + quantization overhead) we see it like keeping things specific to FieldWriter in its `#ramBytesUsed` otherwise all on `Lucene[XYZ]ScalarQuantizedVectorsWriter#ramBytesUsed`? Very likely I might be confused with this accounting code part(lemme know if thats the case) but it would be good to keep accounting local basically. Right now we don't use FieldWriter for quantized fields but we do call quantizationOverheadBytesUsed in both places. Could we simplify keeping the accounting local? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
