jainankitk commented on code in PR #16143:
URL: https://github.com/apache/lucene/pull/16143#discussion_r3323234788
##########
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorerSupplier.java:
##########
@@ -93,7 +93,11 @@ public final BulkScorer bulkScorer() throws IOException {
} else if (scoreMode.needsScores() == false && twoPhase == null) {
return new ConstantScoreBulkScorer(score, scoreMode, iterator);
} else {
- return new Weight.DefaultBulkScorer(new ConstantScoreScorer(score,
scoreMode, iterator));
+ Scorer scorer =
+ twoPhase == null
+ ? new ConstantScoreScorer(score, scoreMode, iterator)
+ : new ConstantScoreScorer(score, scoreMode, twoPhase);
+ return new Weight.DefaultBulkScorer(scorer);
Review Comment:
This seems like a bug fix in addition to other routing changes. Should the
CHANGES entry reflect that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
