romseygeek commented on code in PR #16109:
URL: https://github.com/apache/lucene/pull/16109#discussion_r3334132731
##########
lucene/core/src/test/org/apache/lucene/search/TestDocValuesQueries.java:
##########
@@ -689,6 +690,139 @@ private void assertCount(IndexSearcher searcher, Query
query, int expectedCount)
assertEquals(expectedCount, w.count(searcher.reader.leaves().getFirst()));
}
+ @Test
+ public void testSortedSetDocValuesRangeQueryCount() throws Exception {
+ try (Directory dir = newDirectory();
+ RandomIndexWriter iw = new RandomIndexWriter(random(), dir)) {
+ for (int i = 0; i < 100; i++) {
+ String val = String.format(Locale.ROOT, "%03d", i);
+ Document doc = new Document();
+ doc.add(SortedSetDocValuesField.indexedField("with_index",
newBytesRef(val)));
+ doc.add(new SortedSetDocValuesField("without_index",
newBytesRef(val)));
+ if (i != 55) {
+ doc.add(SortedSetDocValuesField.indexedField("sparse",
newBytesRef(val)));
+ }
+ iw.addDocument(doc);
+ }
+ iw.commit();
+ iw.forceMerge(1);
+
+ try (IndexReader reader = iw.getReader()) {
+ IndexSearcher searcher = new IndexSearcher(reader);
+
+ // Nonexistent field
+ assertCount(
+ searcher,
+ SortedSetDocValuesField.newSlowRangeQuery(
+ "nonexistent", newBytesRef("000"), newBytesRef("099"), true,
true),
+ 0);
+
+ // Below all values: range is entirely before "000"
+ assertCount(
+ searcher,
+ SortedSetDocValuesField.newSlowRangeQuery(
+ "with_index", newBytesRef("!"), newBytesRef("/"), true, true),
+ 0);
+ assertCount(
+ searcher,
+ SortedSetDocValuesField.newSlowRangeQuery(
+ "without_index", newBytesRef("!"), newBytesRef("/"), true,
true),
+ 0);
+ assertCount(
+ searcher,
+ SortedSetDocValuesField.newSlowRangeQuery(
+ "sparse", newBytesRef("!"), newBytesRef("/"), true, true),
+ 0);
+
+ // Match all values: "000" through "099"
+ assertCount(
+ searcher,
+ SortedSetDocValuesField.newSlowRangeQuery(
+ "with_index", newBytesRef("000"), newBytesRef("099"), true,
true),
+ 100);
+ assertCount(
+ searcher,
+ SortedSetDocValuesField.newSlowRangeQuery(
+ "without_index", newBytesRef("000"), newBytesRef("099"), true,
true),
+ -1);
+ assertCount(
+ searcher,
+ SortedSetDocValuesField.newSlowRangeQuery(
+ "sparse", newBytesRef("000"), newBytesRef("099"), true, true),
+ -1);
+
+ // Partial match: "050" through "060" = 11 values
+ assertCount(
Review Comment:
Let's add tests for partial matches against terms that aren't in the index,
eg "0501" to "100"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
