romseygeek commented on code in PR #16162:
URL: https://github.com/apache/lucene/pull/16162#discussion_r3334498589
##########
lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCaseParent.java:
##########
@@ -2728,7 +2732,11 @@ protected LeafSlice[] slices(List<LeafReaderContext>
leaves) {
};
}
ret.setSimilarity(getTestFrameworkInfra().getClassEnv().similarity);
- ret.setQueryCachingPolicy(MAYBE_CACHE_POLICY);
Review Comment:
Oh fun, were we setting a caching policy on something that didn't actually
have a cache?
I do wonder if it's worth tidying up the API here somehow, or maybe throwing
an exception if you try and set a policy on a searcher with no query cache?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
