romseygeek commented on code in PR #16146:
URL: https://github.com/apache/lucene/pull/16146#discussion_r3340083296
##########
lucene/core/src/java/org/apache/lucene/search/Weight.java:
##########
@@ -290,6 +298,16 @@ public int score(LeafCollector collector, Bits acceptDocs,
int min, int max)
return iterator.docID();
}
+ private static boolean canBulkCollectDocIdStream(
+ Scorer scorer, DocIdSetIterator iterator, int min, int max) {
+ if (scorer instanceof ConjunctionScorer conjunctionScorer) {
Review Comment:
I think we want to avoid having special cases such as this in
DefaultBulkScorer. I'd rather look for more places where we can explicitly use
ConstantScoreBulkScorer- for example, the optional-clauses-with-filter case
that you add a test for here can use one I think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
