jegentile opened a new pull request, #16205: URL: https://github.com/apache/lucene/pull/16205
## Summary - Resolve the FIXME in `KnnVectorValues.getAcceptOrds()` (added in #13779): change the default implementation to `return acceptDocs` directly, matching the dense assumption already made by the default `ordToDoc()` (which returns `ord` unchanged) - Remove 10 redundant `getAcceptOrds()` overrides from Dense inner classes that just returned `acceptDocs` - Add missing `getAcceptOrds()` overrides to `ExitableDirectoryReader` (delegates to underlying) and `SimpleTextKnnVectorsReader` (sparse ord-to-doc translation) - Add `testGetAcceptOrdsWithSparseVectors` to `BaseKnnVectorsFormatTestCase` to verify the contract across all codec implementations ## Test plan - [x] `TestLucene104ScalarQuantizedVectorsFormat` (core) - [x] `TestFlatVectorScorer` (core) - [x] `TestSimpleTextKnnVectorsFormat` (codecs) - [x] Backward-codecs test suite (1398 tests) - [x] New `testGetAcceptOrdsWithSparseVectors` passes against Lucene104 and SimpleText - [x] `tidy`, `javadoc`, compilation clean -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
