jeho-rpls commented on code in PR #16403:
URL: https://github.com/apache/lucene/pull/16403#discussion_r3615527840
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/IncrementalHnswGraphMerger.java:
##########
@@ -108,7 +108,7 @@ public IncrementalHnswGraphMerger addReader(
if (reader instanceof PerFieldKnnVectorsFormat.FieldsReader
candidateReader) {
currKnnVectorsReader = candidateReader.getFieldReader(fieldInfo.name);
}
- if (!(reader instanceof HnswGraphProvider)) {
+ if (!(currKnnVectorsReader instanceof HnswGraphProvider)) {
Review Comment:
Yes, re-verified now against the current head: with just these two lines
reverted, the test fails with
```
expected the merged graph to be built by joining the 2 deletion-free source
graphs, but HNSW messages were: [build graph from 3000 vectors, built 0 in 0.01
ms, addVectors [0 3000): 3000 vectors in 587.36 ms]
```
which is the full rebuild path. With the two lines restored, it passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
