romseygeek commented on PR #16411: URL: https://github.com/apache/lucene/pull/16411#issuecomment-5091889457
Thanks @serhiy-bzhezytskyy, this looks great! I'd echo @msokolov's request for a benchmark - I don't think it's likely that this is in a hot path, as we already have various checks to ensure that `updateCompetitiveIterator()` isn't called that's often, but it would be good to double-check. On Mike's second point, this is actually something I've been working on separately and have just opened a PR for: https://github.com/apache/lucene/pull/16424 - currently it only applies to doc-values range queries but I plan on integrating it into TopFieldCollector too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
