gsmiller opened a new pull request, #16482: URL: https://github.com/apache/lucene/pull/16482
### Description I bundled some modernization/cleanup changes here as I saw opportunities while going through this code for another project I'm working on. I think it's worth a modernization pass on this code (much of it is 13 years old). This change includes: 1. Move from java.util maps to hppc maps for primitive typing 2. Small modernizations to be more idiomatic with newer JVMs 3. Marking more methods synchronized (e.g., `PersistentSnapshotDeletionPolicy#getLastSaveFile` could technically have a race condition). 4. Adding consistent error recovery logic to `PersistentSnapshotDeletionPolicy#release(long)` 5. Tightening up the logic in `PersistentSnapshotDeletionPolicy#loadPriorSnapshots` to only read from the latest ref-count file (and to ensure all older files are cleaned up, not relying on the order the filenames are read from the directory). NOTE: This is technically API-breaking since it changes the datatype of protected fields in `SnapshotDeletionPolicy`. Given that this is tagged as `@lucene.experimental`—_and_ given that I don't imagine lots of subclasses in the wild out there (along with the fact that it's an easy migration path in code)—I think it's reasonable to release with 10.6 instead of waiting for 11.0 (but open to feedback of course). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
