vsop-479 commented on PR #16407:
URL: https://github.com/apache/lucene/pull/16407#issuecomment-5202389689
> The current implementation fistly reads the length bytes into
suffixLengthBytes, and then read all lengths from suffixLengthBytes, which is
redundantly.
> I will change it to read lengths directly, hope to get some speedup.
Read lengths directly:
```
TaskQPS baseline StdDevQPS my_modified_version StdDev
Pct diff p-value
BrowseDayOfYearSSDVFacets 7.47 (13.1%) 7.13
(10.8%) -4.6% ( -25% - 22%) 0.230
IntNRQ 2917.59 (6.9%) 2865.20
(10.1%) -1.8% ( -17% - 16%) 0.510
ConstMSM2 2172.59 (8.5%) 2133.88
(7.1%) -1.8% ( -16% - 15%) 0.473
HighTerm 1252.26 (11.1%) 1230.15
(12.5%) -1.8% ( -22% - 24%) 0.637
BrowseDateSSDVFacets 1.41 (10.8%) 1.39
(8.3%) -1.6% ( -18% - 19%) 0.589
OrHighLow 1522.87 (6.5%) 1500.97
(4.9%) -1.4% ( -12% - 10%) 0.431
AndMissingHigh 5505.38 (8.5%) 5435.01
(7.5%) -1.3% ( -15% - 16%) 0.615
BM25MSM2 31.64 (3.1%) 31.27
(3.8%) -1.2% ( -7% - 6%) 0.297
HighTermMonthSort 2028.84 (5.4%) 2006.77
(5.8%) -1.1% ( -11% - 10%) 0.540
OrHighHigh 270.81 (9.5%) 268.35
(9.4%) -0.9% ( -18% - 19%) 0.761
HighTermTitleBDVSort 48.43 (3.6%) 48.11
(3.0%) -0.7% ( -7% - 6%) 0.520
PKLookup 442.97 (1.6%) 440.10
(1.7%) -0.6% ( -3% - 2%) 0.208
HighSpanNear 60.53 (3.3%) 60.22
(4.2%) -0.5% ( -7% - 7%) 0.677
Fuzzy1 86.17 (2.3%) 85.77
(3.9%) -0.5% ( -6% - 5%) 0.647
MedTerm 1574.00 (11.2%) 1566.81
(11.3%) -0.5% ( -20% - 24%) 0.898
Fuzzy2 80.58 (2.6%) 80.26
(1.8%) -0.4% ( -4% - 4%) 0.578
Prefix3 727.49 (5.1%) 724.88
(5.5%) -0.4% ( -10% - 10%) 0.831
OrHighNotLow 1392.30 (7.7%) 1387.30
(8.9%) -0.4% ( -15% - 17%) 0.892
LowSpanNear 49.82 (2.4%) 49.64
(2.7%) -0.3% ( -5% - 4%) 0.673
OrNotHighHigh 393.78 (5.5%) 392.69
(6.7%) -0.3% ( -11% - 12%) 0.887
BrowseRandomLabelSSDVFacets 6.02 (5.7%) 6.02
(10.2%) -0.1% ( -15% - 16%) 0.962
HighIntervalsOrdered 69.36 (4.7%) 69.29
(4.7%) -0.1% ( -9% - 9%) 0.942
AndHighHigh 315.39 (6.7%) 315.11
(7.8%) -0.1% ( -13% - 15%) 0.970
OrHighMed 649.35 (5.8%) 649.84
(6.8%) 0.1% ( -11% - 13%) 0.970
OrHighNotHigh 682.61 (3.2%) 683.24
(4.3%) 0.1% ( -7% - 7%) 0.939
BrowseMonthSSDVFacets 7.88 (19.0%) 7.90
(19.8%) 0.1% ( -32% - 47%) 0.981
MedSloppyPhrase 246.53 (3.8%) 247.01
(2.1%) 0.2% ( -5% - 6%) 0.840
Respell 42.61 (1.8%) 42.72
(1.3%) 0.3% ( -2% - 3%) 0.585
HighSloppyPhrase 69.36 (3.8%) 69.55
(3.5%) 0.3% ( -6% - 7%) 0.811
HighTermTitleSort 123.14 (3.7%) 123.51
(2.5%) 0.3% ( -5% - 6%) 0.766
OrHighMedDayTaxoFacets 16.29 (4.3%) 16.34
(3.4%) 0.3% ( -7% - 8%) 0.794
TermDTSort 302.81 (3.7%) 304.02
(4.5%) 0.4% ( -7% - 8%) 0.759
BrowseMonthTaxoFacets 5.31 (5.6%) 5.34
(4.7%) 0.5% ( -9% - 11%) 0.780
HighTermDayOfYearSort 347.71 (5.4%) 349.36
(4.3%) 0.5% ( -8% - 10%) 0.759
MedSpanNear 151.99 (3.4%) 152.82
(3.3%) 0.5% ( -5% - 7%) 0.605
MedTermDayTaxoFacets 31.10 (2.6%) 31.29
(3.1%) 0.6% ( -5% - 6%) 0.514
AndHighHighDayTaxoFacets 17.33 (2.6%) 17.44
(2.4%) 0.7% ( -4% - 5%) 0.397
MedPhrase 499.60 (3.1%) 503.44
(3.4%) 0.8% ( -5% - 7%) 0.453
AndHighMed 518.64 (6.6%) 522.80
(6.5%) 0.8% ( -11% - 14%) 0.698
MedIntervalsOrdered 169.71 (5.5%) 171.08
(6.0%) 0.8% ( -10% - 13%) 0.657
HighPhrase 23.67 (1.7%) 23.90
(3.0%) 1.0% ( -3% - 5%) 0.211
AndHighMedDayTaxoFacets 265.84 (4.7%) 268.43
(2.7%) 1.0% ( -6% - 8%) 0.426
OrHighNotMed 934.51 (6.1%) 944.41
(6.8%) 1.1% ( -11% - 14%) 0.604
LowTerm 2480.83 (14.7%) 2508.84
(12.8%) 1.1% ( -23% - 33%) 0.796
LowPhrase 279.65 (5.2%) 282.94
(4.4%) 1.2% ( -8% - 11%) 0.442
LowSloppyPhrase 294.43 (5.1%) 298.16
(4.5%) 1.3% ( -7% - 11%) 0.403
Wildcard 77.74 (4.3%) 78.90
(3.8%) 1.5% ( -6% - 9%) 0.239
OrNotHighMed 562.40 (4.0%) 573.02
(4.9%) 1.9% ( -6% - 11%) 0.183
LowIntervalsOrdered 143.50 (5.6%) 146.25
(4.3%) 1.9% ( -7% - 12%) 0.225
range 9536.57 (8.0%) 9740.43
(7.6%) 2.1% ( -12% - 19%) 0.386
AndHighLow 1992.71 (6.6%) 2038.04
(4.9%) 2.3% ( -8% - 14%) 0.215
OrNotHighLow 1695.24 (6.4%) 1741.69
(4.8%) 2.7% ( -8% - 14%) 0.128
BrowseRandomLabelTaxoFacets 4.61 (2.5%) 4.75
(8.7%) 3.0% ( -8% - 14%) 0.146
BrowseDateTaxoFacets 5.11 (2.7%) 5.39
(11.8%) 5.5% ( -8% - 20%) 0.043
BrowseDayOfYearTaxoFacets 5.14 (2.4%) 5.42
(11.6%) 5.5% ( -8% - 20%) 0.037
IntSet 1083.91 (12.6%) 1153.30
(8.0%) 6.4% ( -12% - 30%) 0.055
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
