dweiss commented on code in PR #16483: URL: https://github.com/apache/lucene/pull/16483#discussion_r3735188266
########## build-tools/build-infra/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java: ########## @@ -1,264 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package org.apache.lucene.gradle; - -import static java.nio.file.StandardCopyOption.REPLACE_EXISTING; - -import java.io.IOException; -import java.io.InputStream; -import java.io.OutputStream; -import java.lang.annotation.ElementType; -import java.lang.annotation.Retention; -import java.lang.annotation.RetentionPolicy; -import java.lang.annotation.Target; -import java.net.HttpURLConnection; -import java.net.URI; -import java.net.URL; -import java.nio.charset.StandardCharsets; -import java.nio.file.Files; -import java.nio.file.Path; -import java.nio.file.Paths; -import java.security.MessageDigest; -import java.security.NoSuchAlgorithmException; -import java.util.Locale; -import java.util.Objects; -import java.util.concurrent.TimeUnit; -import java.util.logging.Logger; -import java.util.regex.Pattern; - -/** - * Standalone class used to download the {@code gradle-wrapper.jar}. - * - * <p>Ensure this class has no dependencies outside of standard java libraries as it's used direct - */ -public class WrapperDownloader { - /** - * Copied to keep the class isolated from any other classes. - * - * @see "https://github.com/apache/lucene/issues/15399"; - */ - @Retention(RetentionPolicy.CLASS) - @Target({ElementType.CONSTRUCTOR, ElementType.FIELD, ElementType.METHOD, ElementType.TYPE}) - private @interface SuppressForbidden { - /** A reason for suppressing should always be given. */ - String reason(); - } - - public static void main(String[] args) { - if (args.length != 1) { - System.err.println("Usage: java WrapperDownloader.java <destination>"); - System.exit(2); - } - - try { - checkVersion(); - new WrapperDownloader().run(Paths.get(args[0])); - } catch (Exception e) { - System.err.println("ERROR: " + e.getMessage()); - System.exit(3); - } - } - - public static void checkVersion() { - int major = Runtime.version().feature(); - if (major < 25 || major > 26) { - throw new IllegalStateException("java version must be 25..26, your version: " + major); - } - } - - public void run(Path destination) throws IOException, NoSuchAlgorithmException { - var expectedFileName = destination.getFileName().toString(); - Path checksumPath = destination.resolveSibling(expectedFileName + ".sha256"); - if (!Files.exists(checksumPath)) { - throw new IOException("Checksum file not found: " + checksumPath); - } - - String expectedChecksum; - try (var lines = Files.lines(checksumPath, StandardCharsets.UTF_8)) { - expectedChecksum = - lines - .map( - line -> { - // "The default mode is to print a line with: checksum, a space, - // a character indicating input mode ('*' for binary, ' ' for text - // or where binary is insignificant), and name for each FILE." - var spaceIndex = line.indexOf(" "); - if (spaceIndex != -1 && spaceIndex + 2 < line.length()) { - var mode = line.charAt(spaceIndex + 1); - String fileName = line.substring(spaceIndex + 2); - if (mode == '*' && fileName.equals(expectedFileName)) { - return line.substring(0, spaceIndex); - } - } - - Logger.getLogger(WrapperDownloader.class.getName()) - .warning( - "Something is wrong with the checksum file. Regenerate with " - + "'sha256sum -b gradle-wrapper.jar > gradle-wrapper.jar.sha256'"); - return null; - }) - .filter(Objects::nonNull) - .findFirst() - .orElse(null); - - if (expectedChecksum == null) { - throw new IOException( - "The checksum file did not contain the expected checksum for '" - + expectedFileName - + "'?"); - } - } - - Path wrapperProperties = - destination.resolveSibling( - destination.getFileName().toString().replace(".jar", ".properties")); - if (!Files.exists(wrapperProperties)) { - throw new IOException("Wrapper property file not found: " + wrapperProperties); - } - - Pattern versionPattern = Pattern.compile("gradle-(?<version>.+?)-bin.zip"); Review Comment: So it can download gradle but can't download the wrapper? Maybe we could just modify the location the wrapper is downloaded from so that it's the same as gradle distribution? I don't oppose the change but it breaks Windows, for example - the up-to-date check there is gone and switching between different versions won't work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
