uschindler commented on code in PR #16497:
URL: https://github.com/apache/lucene/pull/16497#discussion_r3747333487
##########
lucene/core/src/java/org/apache/lucene/internal/vectorization/VectorizationProvider.java:
##########
@@ -145,7 +145,7 @@ static VectorizationProvider lookup(boolean testMode) {
return new DefaultVectorizationProvider();
}
// don't use vector module with JVMCI (it does not work)
- if (Constants.IS_JVMCI_VM) {
+ if (Constants.IS_JVMCI_VM && Runtime.version().feature() < 25) {
LOG.warning(
"Java runtime is using JVMCI Compiler; Java vector incubator API
can't be enabled.");
Review Comment:
it would be good to add a statement to the Warning message that at least
Java 25 is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
