When generating a FileActivity or DevActivity report the report contents is
ChangeLog report contents
-----------------------------------------------------------------------------------------------------
Key: MCHANGELOG-12
URL: http://jira.codehaus.org/browse/MCHANGELOG-12
Project: Maven 2.x Changelog Plugin
Type: Bug
Versions: 2.0
Reporter: Martin Johannesen
Priority: Critical
Cause:
DeveloperActivityReport and FileActivityReport both extend ChangeLogReport, but
the method doGenerateReport has changed signature:
ChangeLogReport : void doGenerateReport( List changeLogSets, ResourceBundle
bundle, Sink sink )
DeveloperActivityReport and FileActivityReport: void doGenerateReport(
ChangeLogSet changeLogSets, ResourceBundle bundle, Sink sink )
So when executeReport( Locale locale) is called on DeveloperActivityReport or
FileActivityReport, the "intended" overridden method doGenerateReport is never
called, but the parent doGenerateReport from ChangeLogReport, thus always
generating a ChangeLogReport.
Due to the fact that this plugin has been moved from mojo to maven, i am not
able to see when this change has occured. But a possible fix would be to change
the signature of the above mentioned methods so the parent method gets
overridden correctly and adding an loop looping over the changeLogSets:
{code:title=DeveloperActivityReport.java|borderStyle=solid}
protected void doGenerateReport( List changeLogSets, ResourceBundle bundle,
Sink sink )
{
sink.head();
sink.title();
sink.text( bundle.getString( "report.dev-activity.header" ) );
sink.title_();
sink.head_();
sink.body();
sink.section1();
sink.sectionTitle1();
sink.text( bundle.getString( "report.dev-activity.mainTitle" ) );
sink.sectionTitle1_();
for ( Iterator sets = changeLogSets.iterator(); sets.hasNext(); )
{
ChangeLogSet changeLogSet = (ChangeLogSet) sets.next();
doChangedSets( changeLogSet, bundle, sink );
}
sink.section1_();
sink.body_();
sink.flush();
sink.table_();
}
{code}
{code:title=FileActivityReport|borderStyle=solid}
protected void doGenerateReport( List changeLogSets, ResourceBundle bundle,
Sink sink )
{
sink.head();
sink.title();
sink.text( bundle.getString( "report.file-activity.header" ) );
sink.title_();
sink.head_();
sink.body();
sink.section1();
sink.sectionTitle1();
sink.text( bundle.getString( "report.file-activity.mainTitle" ) );
sink.sectionTitle1_();
for ( Iterator sets = changeLogSets.iterator(); sets.hasNext(); )
{
ChangeLogSet changeLogSet = (ChangeLogSet) sets.next();
doChangedSets( changeLogSet, bundle, sink );
}
sink.section1_();
sink.body_();
sink.table_();
}
{code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
