[ http://jira.codehaus.org/browse/SCM-187?page=comments#action_67650 ]
Richard van der Hoff commented on SCM-187: ------------------------------------------ evenisse and I had a fairly lengthy chat about this on #maven last week. It seems that just making this change may well break backwards compatibility with cvsnt. The current behaviour is certainly wrong, as it passes a quoted argument to System.exec(String[]). Under linux, the argument is passed straight through, without further modification, to the OS and thence to the cvs binary. Under Windows, if memory serves correctly, the String[] array is first joined into a single command line, and then split again by the cvs binary - this extra stage of joining/splitting allows the current broken behaviour to go unnoticed. That doesn't detract from the fact that the fix was put in, deliberately, to make the changelog command work with cvsnt. Without a windows development system handy, it's difficult for me to be exactly certain why it is needed. I suspect the problem lies with cvsnt (implying that the fix should stay in maven-scm-provider-cvs, modified to somehow not break linux - a slightly fudgy test of os.name may well be adequate) but it may also be in System.exec (suggesting a workaround is needed in plexus-cli), or somewhere else again. > CVS changelog creates bad dates for CVS on linux > ------------------------------------------------ > > Key: SCM-187 > URL: http://jira.codehaus.org/browse/SCM-187 > Project: Maven SCM > Type: Bug > Components: maven-scm-provider-cvs > Versions: 1.0-beta-2 > Environment: Linux > Reporter: Jimmy Larsson > Attachments: date_quoting_fix.patch > > > This is related to SCM-177. > SCM-177 presents a patch which fixes timezone problems with the dates sent to > the CVS command, but it also introduces a new bug. > With the current svn source I get commandlines like this when i try to get > changelogs with a startdate set: > cvs -z3 -f -d :pserver:[EMAIL PROTECTED]:/cvsroot -q log -d > '">2006-04-20T11:42:45+0200"' -rBRANCH_1_1 > The problem is that the date has two pairs of qoutes. From the comments on > SCM-177 it seems like this is not an issue on windows. I'm running linux and > my cvs command does not accept the date. > I'm not very used to creating patches but I'll try to create one that fixes > my problem and attach it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
