[ http://jira.codehaus.org/browse/MCLOVER-38?page=comments#action_67958 ] 

John Allen commented on MCLOVER-38:
-----------------------------------

Hi Vincent,

Same use case as the PMD:check, Checkstyle:check and Surefire:test Mojos - 
namely that the flexibility to circumvent certain aspects of a 'governance' 
build (which as you quite rightly say is setup by profile) is very useful. And 
just as important is that we should be striving for consistency across plugins 
with similiar lifecycle semantics (i.e. mojos that check that policy is adhered 
to).

Also worthy of note is that i may wish to run the complete governance build 
from beginning to end to determine which aspects of the build do not adhere to 
the defined governance policy, ie. n PMD/Checkstyle violations, actual coverage 
being less than policy specified minimum n% or a test failure. If each check 
Mojo failed the build immediately, with no option to simply print a warning 
message out stating that it has failed to pass the governance policy, one would 
have to fix that failure before proceeding to the next aspect of the governance 
build.

Note that IMO controlling each aspect of governance build with a seprate 
profile is not applicable, a profile is for use by developers and as such 
having to specify multiple profiles on the CLI is not very convient, not to 
mention the fact that by not running the clover:check Mojo I will not know 
whether it would fail the defined policy.




> Allow check Mojo to be overriden by a ${clover.failOnViolation} parameter in 
> the same way pmd and checkstyle can
> ----------------------------------------------------------------------------------------------------------------
>
>          Key: MCLOVER-38
>          URL: http://jira.codehaus.org/browse/MCLOVER-38
>      Project: Maven 2.x Clover Plugin
>         Type: Improvement

>     Versions: 2.1
>  Environment: 2.0.4
>     Reporter: John Allen
>     Priority: Minor

>
>
> Add a ${clover.failOnViolation} parameter to allow a check failure to be 
> overriden on the command line in line with the PMD and Checkstyle check Mojos

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to