Plugin not longer sets system properties when forking is on and debugging
information is not correct
----------------------------------------------------------------------------------------------------
Key: MSUREFIRE-145
URL: http://jira.codehaus.org/browse/MSUREFIRE-145
Project: Maven 2.x Surefire Plugin
Type: Bug
Versions: 2.3
Reporter: Vincent Massol
Priority: Blocker
The following code is in SurefirePlugin.java:
{code:java}
processSystemProperties( !fork.isForking() );
if ( getLog().isDebugEnabled() )
{
showMap( systemProperties, "system property" );
}
{code}
2 problems:
1) fork.isForking() is false when forking is enabled and thus system properties
are not set:
{code:java}
protected void processSystemProperties( boolean setInSystem )
{
[...]
if ( setInSystem )
{
// Add all system properties configured by the user
Iterator iter = systemProperties.keySet().iterator();
while ( iter.hasNext() )
{
String key = (String) iter.next();
String value = systemProperties.getProperty( key );
System.setProperty( key, value );
}
}
}
{code}
2) showMap() is called regardless of whether the system properties are set or
not, leading to the following kind of misleading logs:
{noformat}
[...]
[DEBUG] Setting system property [cargo.jetty4x.port]=[8280]
[DEBUG] Setting system property [cargo.jetty6x.port]=[8280]
[DEBUG] Setting system property [cargo.jetty5x.port]=[8280]
[...]
{noformat}
Those properties are actually NOT set.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
