[ http://jira.codehaus.org/browse/CONTINUUM-771?page=comments#action_69695
]
Carlos Sanchez commented on CONTINUUM-771:
------------------------------------------
The handling of exceptions needs to be improved
+ catch (ContinuumException ce )
+ {
+ addActionError( "Can't get continuum users: " + ce.getMessage() );
+
+ ce.printStackTrace();
+
+ return ERROR;
+ }
- printStackTrace() must not be called.
- Adding the exception message to the action error is not a good idea, it can
be any kind of strange message
- Use the log to print the error
protected transient static final Log LOG = LogFactory.getLog(MyClass.class);
- not sure, but the ActionError parameter is probably a key that can be looked
up in the localization files to show different errors in different lenguages,
and the message for the user is probably "An internal error has occurred",
while in the LOG something more meaninful for administrators is used
> Add user management screens
> ---------------------------
>
> Key: CONTINUUM-771
> URL: http://jira.codehaus.org/browse/CONTINUUM-771
> Project: Continuum
> Type: Sub-task
> Components: Web interface
> Reporter: Carlos Sanchez
> Assignee: Henry S. Isidro
> Fix For: 1.1
> Attachments: CONTINUUM-771-continuum-webapp.patch
>
>
> Add a page for listing the users, with options to add/edit/delete user
> Users can have an unlimited number of roles (Continuum Permission) like
> addProject, addUser,... they are already created by the ContinuumInitializer
> and are static (no new roles/permissions can be added)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
