[ http://jira.codehaus.org/browse/CONTINUUM-779?page=all ]
Carlos Sanchez updated CONTINUUM-779:
-------------------------------------
Attachment: CONTINUUM-779.patch
Updated patch against trunk.
Comments:
remove the e.printStackTrace commands, that will print them on stdout
when exceptions are not rethrown again, use log.x(String , Exception ) instead
of log.x(String), that way the exception stacktrace will be printed in the
logger. If they are rethrown again you don't want to log them, they must be
logged in another layer that catches them
addActionError must be used with a meaningful error for the user, eg. "your
user id already exists, please choose another", never something like "jdbc
error xx", so never append the exception message there.
Related to previous is CONTINUUM-778, where we try to avoid dealing with
internal errors outside of actions, so most of the exception handling code in
actions probably will be removed.
> Creation of AbstractActionLogger that extends ActionSupport and implements
> LogEnabled
> -------------------------------------------------------------------------------------
>
> Key: CONTINUUM-779
> URL: http://jira.codehaus.org/browse/CONTINUUM-779
> Project: Continuum
> Issue Type: Sub-task
> Reporter: Teodoro Cue Jr.
> Attachments: AXPENTBUILDENV-60-continuum-webapp.patch,
> CONTINUUM-779.patch
>
>
> A class that will be use by all actions. This is to eliminate code repetition
> when actions implements the LogEnabled interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
