[ http://jira.codehaus.org/browse/MRM-146?page=comments#action_72003 ] Brett Porter commented on MRM-146: ----------------------------------
I'm currently reviewing this. Things I've modified so far: - fixed code reformatting (moving imports) - removed the changes to the test case that introduced assertRecord. This seems to error prone to maintain, and would prefer to keep using the equals() method - added the sha1bytecodechecksum to the equals method - guaranteed md != null and removed the extra checks - removed setAlgorithm, used internal methods instead - split digester into two interfaces - a streaming digester, and the original one > Updates to MRM-Util's Digester to support incremental hashcodes/checksums > ------------------------------------------------------------------------- > > Key: MRM-146 > URL: http://jira.codehaus.org/browse/MRM-146 > Project: Maven Repository Manager > Issue Type: Improvement > Reporter: Joakim Erdfelt > Assigned To: Brett Porter > Attachments: MRM-146-Digester_Updates.diff, MRM-DIGESTER.diff > > > In order to support a more robust checksum routine needed for automatic jar > discovery operations in MRM and MPIR, a set of new functions to allow for > incremental digester calculations have been created. > These routines are in use by MNG-2489 to produce a bytecode checksum needed > for a more accurate way to identify unknown artifacts. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
