[ http://jira.codehaus.org/browse/MDEPLOY-38?page=comments#action_73778 ] Maarten Brugman commented on MDEPLOY-38: ----------------------------------------
Yes, I know, and I got it working. My point is that anything between the first // and / is assumed to be 'localhost' and thus ignored, even if it contains backslashes. See the example in my previous comment above. That results in behavior I did not expect. Also, if there is no / after the //, but only backslashes (e.g. file://\\host\share\repo), it works. I see several changes that could make the behavior clearer: - if there is anything between // and /, fail - if there is anything between // and /, show a warning that this will be ignored - explain the behavior in the documentation My 2 cents, I hope you agree and then find the time to do something with it. I appreciate the work you have done so far on this module. > deploy:deploy-file fails silently on Windows URL containing invalid host name > or share > -------------------------------------------------------------------------------------- > > Key: MDEPLOY-38 > URL: http://jira.codehaus.org/browse/MDEPLOY-38 > Project: Maven 2.x Deploy Plugin > Issue Type: Bug > Affects Versions: 2.2.1 > Environment: Windows > Reporter: Maarten Brugman > Priority: Minor > > When using goal deploy:deploy-file, and a Windows URL is used of the form > "file://host/share/...." containing an invalid host name or share, maven > reports XXX K uploaded and BUILD SUCCESSFUL. > NOTE: if a URL of the form "file://\\nonexistenthost\share\..." is used, the > command fails as expected. However, as soon as one backslash after "share" is > replaced by a frontslash, the goal fails silently (i.e. reports success). > Example of silent failure: > mvn deploy:deploy-file -Detc.... > -Durl=file://nonexistenthost/share/Maven-repository > --> output: > [INFO] Scanning for projects... > [INFO] Searching repository for plugin with prefix: 'deploy'. > [INFO] > ---------------------------------------------------------------------------- > [INFO] Building Maven Default Project > [INFO] task-segment: [deploy:deploy-file] (aggregator-style) > [INFO] > ---------------------------------------------------------------------------- > [INFO] [deploy:deploy-file] > Uploading: > file://nonexistenthost/share/Maven-repository/javax/faces/jsf-impl/1.1/jsf-impl-1.1.jar > 673K uploaded > [INFO] Retrieving previous metadata from remote-repository > [INFO] Uploading repository metadata for: 'artifact javax.faces:jsf-impl' > [INFO] Retrieving previous metadata from remote-repository > [INFO] Uploading project information for jsf-impl 1.1 > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESSFUL > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1 second > [INFO] Finished at: Tue Jul 25 16:47:00 CEST 2006 > [INFO] Final Memory: 2M/4M > [INFO] > ------------------------------------------------------------------------ -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
