[ 
https://issues.apache.org/jira/browse/MNG-5947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15080513#comment-15080513
 ] 

ASF GitHub Bot commented on MNG-5947:
-------------------------------------

Github user jvanzyl commented on the pull request:

    https://github.com/apache/maven/pull/74#issuecomment-168534190
  
    General rule of thumb is that a change in resolution will definitely not go 
in if it changes the default behaviour within a minor version. First smoke test 
is making sure the ITs pass, second smoke test is that I run it against 40-50 
projects I use as a sampling. So at least make sure the core integration tests 
pass. If it does change resolution within a minor version then it needs to be 
activated consciously on the users part. If this is deemed an improvement it 
can become something activated by default in 4.x possibly.
    
    For better or worse the way Maven resolves dependencies currently is how it 
works for everyone. Making changes to this and possibly selecting different 
versions of dependencies based on different rules can potentially break a lot 
of people.


> dependencyManagement import section does not resolve dependencies using 
> "nearest" definition
> --------------------------------------------------------------------------------------------
>
>                 Key: MNG-5947
>                 URL: https://issues.apache.org/jira/browse/MNG-5947
>             Project: Maven
>          Issue Type: Bug
>          Components: Dependencies
>    Affects Versions: 3.3.3
>            Reporter: MichaƂ Kowalcze
>         Attachments: MNG-5947-poms.tgz
>
>
> While resolving dependencies for dependencyManagement version of a particular 
> dependency is determined using "first match", not "nearest" definition.
> Assuming that we have:
> * parent:3.2.1:pom with commons-collections:3.2.1 in dependencyManagement
> * parent:3.2.2:pom with commons-collections:3.2.2 in dependencyManagement
> * imported:1.0:pom with dependencyManagement importing parent:3.21
> * final:1.0:pom with dependencyManagement importing imported:1.0 and 
> parent:3.2.2
> then dependency version for commons-collections in the final POM is set to 
> 3.2.1 (as import 1.0 / parent 3.2.1 is first match), not 3.2.2 which is 
> nearer (one level of import vs. two levels for 3.2.1).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to