[ https://issues.apache.org/jira/browse/SCM-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220390#comment-15220390 ]
ASF GitHub Bot commented on SCM-797: ------------------------------------ GitHub user atomicknight opened a pull request: https://github.com/apache/maven-scm/pull/49 SCM-797: Workaround for Windows command line length limitation As suggested by PLXUTILS-107 and implemented by gwt-maven-plugin, it is possible to avoid the Windows command line length limitation by invoking the executable directly instead of via a shell. This commit adapts the gwt-maven-plugin implementation to supply a fake Shell in Windows environments in order to invoke the Git executable directly. You can merge this pull request into a Git repository by running: $ git pull https://github.com/atomicknight/maven-scm cmd_length_workaround Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-scm/pull/49.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #49 ---- commit ebc3896c5ff933f67b9488b3d8af9c9decb17350 Author: Abraham Lin <abraham....@post.harvard.edu> Date: 2016-03-31T18:09:54Z SCM-797: Workaround for Windows command line length limitation As suggested by PLXUTILS-107 and implemented by gwt-maven-plugin, it is possible to avoid the Windows command line length limitation by invoking the executable directly instead of via a shell. This commit adapts the gwt-maven-plugin implementation to supply a fake Shell in Windows environments in order to invoke the Git executable directly. ---- > Fix for windows command line length limitation > ---------------------------------------------- > > Key: SCM-797 > URL: https://issues.apache.org/jira/browse/SCM-797 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-git > Affects Versions: 1.9.4 > Environment: Windows > Reporter: Radovan Murin > Assignee: Robert Scholte > Priority: Critical > Labels: Maven, SCM > > Hello, > I noticed that for a project with a large amount of pom files the prepare > command of the release plugin fails when it tries to git add all of the poms. > The failure happens because the SCM plugin attempts to git add all of the > files at once which fails on Windows machines due to the command line length > limitation. > I have written a small fix and created a pull request > https://github.com/apache/maven-scm/pull/30 > Basicaly, with the fix, the command git add iterates on all files rather than > adding them in one command. The fix was already present in the code in > the GitAddCommand.java. However there was one more place in the code with the > bug. -- This message was sent by Atlassian JIRA (v6.3.4#6332)