[
https://issues.apache.org/jira/browse/SUREFIRE-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15462384#comment-15462384
]
ASF GitHub Bot commented on SUREFIRE-1254:
------------------------------------------
Github user hboutemy commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/117#discussion_r77447554
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/log/PluginConsoleLogger.java
---
@@ -0,0 +1,126 @@
+package org.apache.maven.plugin.surefire.log;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.plugin.logging.Log;
+import org.apache.maven.surefire.report.ConsoleLogger;
+
+/**
+ * Wrapper logger of miscellaneous (Maven 2.2.1 or 3.1) implementations of
{@link Log}.
+ * Calling {@link Log#isInfoEnabled()} before {@link
Log#info(CharSequence)} due to Maven 2.2.1.
+ *
+ * @author <a href="mailto:tibordig...@apache.org";>Tibor Digana
(tibor17)</a>
+ * @since 2.19.2
+ * @see ConsoleLogger
+ */
+public final class PluginConsoleLogger
+ implements ConsoleLogger
+{
+ private final Log mojoLogger;
+
+ public PluginConsoleLogger( Log mojoLogger )
+ {
+ this.mojoLogger = mojoLogger;
+ }
+
+ public boolean isDebugEnabled()
+ {
+ return mojoLogger.isDebugEnabled();
+ }
+
+ public void debug( String message )
+ {
+ if ( mojoLogger.isDebugEnabled() )
+ {
+ mojoLogger.debug( message );
--- End diff --
wow, the whole message with debug level color, and more generally each
message with level color? this will give too much color.
I need to see the effective result, but if it's really what I fear, it was
not the intent when adding color to Maven output: the intent is just to have a
few colored words with general normal message (and nothing else than level with
level color)
> add color messages
> ------------------
>
> Key: SUREFIRE-1254
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1254
> Project: Maven Surefire
> Issue Type: New Feature
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
> Reporter: Hervé Boutemy
> Assignee: Tibor Digana
> Fix For: 2.19.2
>
>
> with MNG-3507 fixed, adding colors to tests results would improve readability
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
