[ 
https://issues.apache.org/jira/browse/MSHARED-610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schulte updated MSHARED-610:
--------------------------------------
    Description: 
{{org.apache.maven.shared.utils.xml.PrettyPrintXMLWriter}} internally uses a 
{{java.io.PrintWriter}}. That class is catching all {{IOException}} s 
internally and does not propagate any exception itseld. Instead the 
{{checkError}} method is provided to check for any error during performing IO. 
The {{PrettyPrintXMLWriter}} must not silently ingore any exception during 
writing and either needs to provide a {{checkError}} method itself (to follow a 
bad idea) or should be updated to check for any IO errors and throw an 
exception.


  was:
{{org.apache.maven.shared.utils.xml.PrettyPrintXMLWriter}} internally uses a 
{{java.io.PrintWriter}}. That class is catching all {{IOException}}s internally 
and does not propagate any exception itseld. Instead the { {checkError}} method 
is provided to check for any error during performing IO. The 
{{PrettyPrintXMLWriter}} must not silently ingore any exception during writing 
and either needs to provide a {{checkError}} or should be updated to check for 
any IO errors {{checkError}} and throw an exception.



> PrettyPrintXMLWriter internally uses java.io.PrintWriter without checking for 
> any errors.
> -----------------------------------------------------------------------------------------
>
>                 Key: MSHARED-610
>                 URL: https://issues.apache.org/jira/browse/MSHARED-610
>             Project: Maven Shared Components
>          Issue Type: Bug
>            Reporter: Christian Schulte
>            Assignee: Christian Schulte
>            Priority: Critical
>
> {{org.apache.maven.shared.utils.xml.PrettyPrintXMLWriter}} internally uses a 
> {{java.io.PrintWriter}}. That class is catching all {{IOException}} s 
> internally and does not propagate any exception itseld. Instead the 
> {{checkError}} method is provided to check for any error during performing 
> IO. The {{PrettyPrintXMLWriter}} must not silently ingore any exception 
> during writing and either needs to provide a {{checkError}} method itself (to 
> follow a bad idea) or should be updated to check for any IO errors and throw 
> an exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to