[
https://issues.apache.org/jira/browse/WAGON-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812708#comment-15812708
]
ASF GitHub Bot commented on WAGON-485:
--------------------------------------
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-wagon/pull/32#discussion_r95234762
--- Diff:
wagon-providers/wagon-ssh/src/main/java/org/apache/maven/wagon/providers/ssh/jsch/ScpWagon.java
---
@@ -297,7 +297,7 @@ public void fillInputData( InputData inputData )
throw new IOException( "Invalid transfer header: " + line
);
}
- int filesize = Integer.valueOf( line.substring( 5, index )
).intValue();
+ long filesize = Long.valueOf( line.substring( 5, index ) );
--- End diff --
Good point. Waiting for this to be integrated and I will ran all tests
against the patch.
> Integer Filesize
> ----------------
>
> Key: WAGON-485
> URL: https://issues.apache.org/jira/browse/WAGON-485
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-ssh
> Affects Versions: 2.10
> Reporter: Silvio Assuncao
> Priority: Critical
>
> ScpWagon class parse a String value to Integer (Filesize) but if you have a
> large file (3.6GB for example) the file size is 3865470566 in bytes, the
> number is more than the MAX_VALUE of Integer.
> {code:title=ScpWagon.java|borderStyle=solid}
> public void fillInputData( InputData inputData )
> throws TransferFailedException, ResourceDoesNotExistException {
> ...
> int filesize = Integer.valueOf( line.substring( 5, index ) ).intValue();
> fireTransferDebug( "Remote file size: " + filesize );
> resource.setContentLength( filesize );
> ...
> {code}
> I changed the line to parse using Long, because the
> *resource.setContentLength* method receive a long value too
> {code:title=ScpWagon.java|borderStyle=solid}
> long filesize = Long.valueOf( line.substring( 5, index ) );
> {code}
> Please check the pull-request https://github.com/apache/maven-wagon/pull/32
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
