[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15814484#comment-15814484
]
Michael Benz commented on DOXIASITETOOLS-172:
---------------------------------------------
border="0" can be removed. I was overzealous in making sure no borders are
displayed around the banner. That should be the users's choice.
If I use the same alt definition as in the fluido skin, unit test
DefaultSiteRenderer fails:
{quote}
Message: Attribute "alt" is required and must be specified for element type
"img".
{quote}
Therefore I need to leave the empty {code}alt=""{code} tag in case neither name
nor alt are defined for the banner image.
> Width, height and border values not used for banner display
> -----------------------------------------------------------
>
> Key: DOXIASITETOOLS-172
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-172
> Project: Maven Doxia Sitetools
> Issue Type: Bug
> Components: Site renderer
> Affects Versions: 1.7.4
> Reporter: Michael Benz
> Priority: Minor
> Attachments: enable-width-height-border-doxia-sitetools.patch
>
>
> Similar to the issue MSKINS-16 that was fixed for the Fluido skin the Default
> Skin ignores the width and height and border settings in the site descriptor.
> The changes in site.xml were introduced here:
> DOXIASITETOOLS-58
> {code}
> <bannerLeft>
> <name>Name</name>
> <src>Logo.svg</src>
> <width>30</width>
> <height>10</height>
> <title>Logo Title</title>
> <border>2</border>
> </bannerLeft>
> {code}
> Created HTML:
> {code}
> <img src="Logo.svg" alt="Name" title="Logo Title">
> {code}
> The CSS in maven-base.css would anyways not allow for a border around any
> image - one would need to create a new skin for borders or remove the
> border:none from the img tag.
> {code}
> /* from maven-base.css */
> img {
> border:none;
> }
> /* (...) */
> #banner img {
> border: none;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
