[ 
https://issues.apache.org/jira/browse/MINVOKER-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826795#comment-15826795
 ] 

Robert Scholte commented on MINVOKER-214:
-----------------------------------------

I thought about it, but it is not correct, because that would suggest that 
{{invoker.goals.1}} are only executed when matching {{invoker.java.version.1}} 
and  {{invoker.goals.2}} when matching {{invoker.java.version.2}}. What we want 
is: call all (indexed) goals when at least one selector criteria is matched.
Also, if you take a look which properties are indexed, those are the ones being 
passed to the maven-invoker component.
So there's a huge differenct between the selector properties and the invoker 
properties, hence doing it with a different prefix should make that clear.

And yes, I should update that page as well.

> Allow indexed maven.version and os.familiy in invoker.properties
> ----------------------------------------------------------------
>
>                 Key: MINVOKER-214
>                 URL: https://issues.apache.org/jira/browse/MINVOKER-214
>             Project: Maven Invoker Plugin
>          Issue Type: Task
>    Affects Versions: 2.0.0
>            Reporter: Robert Scholte
>            Assignee: Robert Scholte
>             Fix For: 3.0.0
>
>
> MINVOKER-209 requires two criteria to run, i.e:
> - Always for non-windows
> - When Windows, run it only with Maven 3.5.0+
> For {{maven.version}}, {{os.family}} and {{java.version}} indexed keys are 
> not allowed (undocumented!), because it makes it much easier to explain why 
> the IT didn't run. In fact, there are much more properties which don't work 
> with an index.
> We could clone the test, but that implies you need to keep both ITs in sync.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to