[
https://issues.apache.org/jira/browse/MSHADE-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830072#comment-15830072
]
Diego Rivera commented on MSHADE-244:
-------------------------------------
I understand your point, and I agree. However, the given configuration
*should* have reproduced the error (on Linux). I'll test it again later today
and validate the conditions under which this can happen. I do remember this
was a source of frustration until I came up with this patch.
Cheers.
> Avoid file copy and replacement when source and target files are the same file
> ------------------------------------------------------------------------------
>
> Key: MSHADE-244
> URL: https://issues.apache.org/jira/browse/MSHADE-244
> Project: Maven Shade Plugin
> Issue Type: Bug
> Affects Versions: 2.4.3
> Reporter: Diego Rivera
> Priority: Blocker
> Attachments: MSHADE-244_selfReplace.patch, shade.no-replace.patch
>
>
> When Shade::replaceFile() is invoked, and the source and target are the same,
> no work should be performed since this can result in an attempt at copying
> the same file upon itself, and the target will end up as a 0-byte file.
> Instead, the proposed patch (attached) adds a check to perform a best-attempt
> intercept of that condition and avoid any unnecessary work.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
