[ 
https://issues.apache.org/jira/browse/SUREFIRE-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213859#comment-16213859
 ] 

Tibor Digana edited comment on SUREFIRE-1424 at 10/21/17 11:50 AM:
-------------------------------------------------------------------

[~eolivelli]
Flag=config param means for me that this configuration would be obsolete in 
Java 10, and I do not want to maintain one more parameter, therefore I vote to 
drop the feature {{-add-modules java.ee.se}} of version 2.20.1 and commit the 
removal in 2.21.0.Jigsaw. Of course old documentation should stay and a new one 
should be added related to 2.21.0.
We already have too many configuration parameters, so better to drop this and 
throw exception on Build Error (if any test fails) with clear link to our 
documentation (if Java specification version >= 9).
The documentation in Surefire should mention on how to use Maven profiles, 
{{-add-modules java.ee.se}} in {{argLine}} for version 2.21.0 or higher, Maven 
dependencies substituting removed API and implementation, and a link to Jigsaw 
doc where Oracle must update it.
If somebody removes a feature, he should obviously take care of writing 
documentation which gives the user alternatives and contact the communities 
about consequencies.


was (Author: tibor17):
[~eolivelli]
Flag=config param means for me that this configuration would be obsolete in 
Java 10, and I do not want to maintain one more parameter, therefore I vote to 
drop the feature {{-add-modules java.ee.se}} of version 2.20.1 and commit the 
removal in 2.21.0.Jigsaw. Of course old documentation should stay and a new one 
should be added related to 2.21.0.
We already have too many configuration parameters, so better to drop this and 
throw exception on Build Error (if any test fails) with clear link to our 
documentation (if Java specification version >= 9).
The documentation in Surefire should mention on how to use Maven profiles, 
{{-add-modules java.ee.se}} in {{argLine}} for version 2.21.0 or higher, Maven 
dependencies substituting removed API and implementation, and a link to Jigsaw 
which Oracle must be update.
If somebody removes a feature, he should obviously take care of writing 
documentation which gives the user alternatives and contact the communities 
about consequencies.

> javax.transaction.TransactionManager not visible with Java9
> -----------------------------------------------------------
>
>                 Key: SUREFIRE-1424
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1424
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Plugin
>    Affects Versions: 2.20.1
>         Environment: Apache Maven 3.5.0 
> (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T21:39:06+02:00)
> Maven home: /Users/snicoll/tools/maven
> Java version: 9, vendor: Oracle Corporation
> Java home: /Library/Java/JavaVirtualMachines/jdk-9.jdk/Contents/Home
> Default locale: en_BE, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>            Reporter: Stephane Nicoll
>            Assignee: Tibor Digana
>
> I am trying to port Spring Boot to Java9 and I am hitting an issue that looks 
> like Maven specific. I've managed to trim down the problem to [a simple class 
> that doesn't involve Spring 
> Boot|https://github.com/snicoll-scratches/test-jta-java9]
> If I run this project on the command line, I get the following:
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.043 s <<< 
> FAILURE! - in com.example.testjtajava9.TestJtaJava9ApplicationTests
> contextLoads(com.example.testjtajava9.TestJtaJava9ApplicationTests)  Time 
> elapsed: 0.006 s  <<< ERROR!
> java.lang.NoClassDefFoundError: javax/transaction/TransactionManager
>       at 
> com.example.testjtajava9.TestJtaJava9ApplicationTests.contextLoads(TestJtaJava9ApplicationTests.java:9)
> Caused by: java.lang.ClassNotFoundException: 
> javax.transaction.TransactionManager
>       at 
> com.example.testjtajava9.TestJtaJava9ApplicationTests.contextLoads(TestJtaJava9ApplicationTests.java:9)
> {noformat}
> If I run that test with IntelliJ IDEA, it passes. This sample project has 
> also a simple Gradle build that shows it works with Gradle as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to