Robin Müller created MNG-6296:
---------------------------------

             Summary: New option -Dstyle.color is not working
                 Key: MNG-6296
                 URL: https://issues.apache.org/jira/browse/MNG-6296
             Project: Maven
          Issue Type: Bug
    Affects Versions: 3.5.2
            Reporter: Robin Müller


The new option {{-Dstyle.color=(auto|always|never)}} is not working. This 
happens as the corresponding code accesses the {{UserProperties}} of the 
{{CliRequest}} before they are set. I'll provide a quick fix for this by 
changing the order of the methods in the {{doMain}} method so the properties 
will be set at the right time.
But I'd suggest to refactor the whole stuff so the code will become easier to 
understand and maintain. IMHO the functionality of the {{properties}} method in 
the {{MavenCli}} should be moved to the constructor of the {{CliRequest}}. The 
{{CliRequest}} itself should be immutable so all fields will have the correct 
content all the time.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to