[
https://issues.apache.org/jira/browse/MNG-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220127#comment-16220127
]
ASF GitHub Bot commented on MNG-6296:
-------------------------------------
GitHub user coder-hugo opened a pull request:
https://github.com/apache/maven/pull/135
[MNG-6296] Parse properties before configuring the logging settings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/coder-hugo/maven colored-output-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven/pull/135.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #135
----
commit 55b62fcac90db1042990e5d3cb954f8cf639c219
Author: Robin Müller <[email protected]>
Date: 2017-10-26T07:41:20Z
[MNG-6296] Parse properties before configuring the logging settings
----
> New option -Dstyle.color is not working
> ---------------------------------------
>
> Key: MNG-6296
> URL: https://issues.apache.org/jira/browse/MNG-6296
> Project: Maven
> Issue Type: Bug
> Affects Versions: 3.5.2
> Reporter: Robin Müller
>
> The new option {{-Dstyle.color=(auto|always|never)}} is not working. This
> happens as the corresponding code accesses the {{UserProperties}} of the
> {{CliRequest}} before they are set. I'll provide a quick fix for this by
> changing the order of the methods in the {{doMain}} method so the properties
> will be set at the right time.
> But I'd suggest to refactor the whole stuff so the code will become easier to
> understand and maintain. IMHO the functionality of the {{properties}} method
> in the {{MavenCli}} should be moved to the constructor of the {{CliRequest}}.
> The {{CliRequest}} itself should be immutable so all fields will have the
> correct content all the time.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
