[ 
https://issues.apache.org/jira/browse/MSITE-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248389#comment-16248389
 ] 

Hervé Boutemy commented on MSITE-801:
-------------------------------------

bq. t's kind of awful to have to effectively re-implement the built-in menu 
stuff just because we want to add a few custom characters to some of the menus
did you know that when creating a skin, you're de-facto re-implementing the 
built in menu stuff?
I suppose that most people just copy the file, completely ignoring that.
But just look at the first macro in 
https://github.com/apache/maven-fluido-skin/blob/master/src/main/resources/META-INF/maven/site-macros.vm
"menu stuff" is just not part of Doxia Site Rendering: it's part of each skin

that's why in MSKINS-128 I split site.vm into site.vm+site-macros.vm: just to 
ease maintenance by differentiating the general html template part from the 
macros doing menus, breadcrumbs and so on

what we can do is adding the feature to Fluido skin, using a convention on img 
content (specific form of url): this way, people copy/pasting Fluido 
site-macros.vm will have the feature, which will be kind of shared...

> Expand features in site.xml for menus
> -------------------------------------
>
>                 Key: MSITE-801
>                 URL: https://issues.apache.org/jira/browse/MSITE-801
>             Project: Maven Site Plugin
>          Issue Type: New Feature
>            Reporter: Allen Wittenauer
>            Priority: Minor
>
> The short story is that I'm looking for a way to configure FontAwesome icons 
> in menu items.
> (for an example, see https://yetus.apache.org/ 's Get Involved menu as built 
> with Middleman 3.)
> Since that's rather specific :), there does seem to be a feature gap here. It 
> would be really useful if site.xml parsing could support either optional 
> fields to pass to skins, allow HTML elements in menu items, or some other way 
> that this could be accomplished.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to