[ 
https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302904#comment-16302904
 ] 

ASF GitHub Bot commented on SUREFIRE-1372:
------------------------------------------

Github user mpkorstanje commented on the issue:

    https://github.com/apache/maven-surefire/pull/150
  
    >  The build passed successfully. I will refactor little details, I will 
squash our commits and then I will push it to master.
    
    Cheers.
    
    > I could not find a documentation for configuring annotation
    
    I've changed the layout of the project to match the default used by 
cucumber. When using the default layout  `@CucumberOptions` is not needed. 
Cucumber uses the location of the runner class to figure out where the features 
and glue are. 
    
    All in all  `@CucumberOptions` influences which features are included but 
doesn't change how cucumber presents itself to surefire. From surefires 
perspective it should be yet another junit test suite. 
    
    > One more question I have is regarding artifacts of Cucumber. Which one is 
right to use:
    
    `cucumber-junit` provides integration with junit and should be used when 
junit is to be used. `cucumber-java` provides java annotations to denote step 
definitions. `cucumber-java8` depends on `cucumber-java` and adds lambda based 
step  definitions. Using `cucumber-java` is sufficient.


> Rerunning failing tests fails in combination with 
> Description#createSuiteDescription
> ------------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-1372
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1372
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Plugin
>    Affects Versions: 2.20
>            Reporter: M.P. Korstanje
>            Assignee: Tibor Digana
>             Fix For: 2.21.1
>
>
> When using surefire to rerun failing tests created by a Runner that uses 
> {noformat}Description#createSuiteDescription{noformat} with a human readable 
> name rather then a class name the following stack trace occurs:
> {code}
> org.apache.maven.surefire.testset.TestSetFailedException: Unable to create 
> test class 'Scenario: Fail when running'
>         at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeFailedMethod(JUnit4Provider.java:385)
>         at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:292)
>         at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
>         at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
> Caused by: java.lang.ClassNotFoundException: Scenario: Fail when running
>         at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeFailedMethod(JUnit4Provider.java:379)
>         at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:292)
>         at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
>         at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to