ppalaga commented on a change in pull request #10: [MPLUGIN-331] Let plugin:report support takari-maven-plugin packaging URL: https://github.com/apache/maven-plugin-tools/pull/10#discussion_r160058324
########## File path: maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java ########## @@ -197,9 +197,18 @@ @Component private RuntimeInformation rtInfo; + /** + * Path to {@code plugin.xml} plugin descriptor to generate the report from. + * + * @since 3.5.1 + */ + @Parameter( defaultValue = "${project.build.outputDirectory}/META-INF/maven/plugin.xml", required = true ) Review comment: Thanks for the explanation, @rfscholte . But https://maven.apache.org/ref/3.5.2/maven-plugin-api/ seems to define the the location of the `plugin.xml` within the `jar` rather than its location in the source tree. This `pluginXmlFile` indeed is a location in the source tree and this `PluginReport` is a report mojo that will not impact the location of `plugin.xml` in the jar in any way. That said, I cannot see how a writable `pluginXmlFile` can violate the maven-plugin-api. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services