[
https://issues.apache.org/jira/browse/SUREFIRE-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480625#comment-16480625
]
ASF GitHub Bot commented on SUREFIRE-1522:
------------------------------------------
docrjp commented on issue #185: [SUREFIRE-1522] fix escapeBytesToPrintable
bounds check
URL: https://github.com/apache/maven-surefire/pull/185#issuecomment-390201339
@Tibor17 whoops sorry, that's my bad for being impatient! I've amended the
commit as requested, and the tests are now progressing through surefire-its.
This bit was taking hours when I first checked out the project, but so far so
good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> IndexOutOfBoundsException for System.out.write
> ----------------------------------------------
>
> Key: SUREFIRE-1522
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1522
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin, process
> forking
> Affects Versions: 2.21.0
> Reporter: Rob Platt
> Assignee: Tibor Digana
> Priority: Major
> Fix For: 2.22.0
>
>
> There is a regression, I believe caused by -SUREFIRE-1454-. Git blame seems
> to confirm this; and there was a related regression for empty arrays
> SUREFIRE-1515.
> It can be easily reproduced with the following test:
>
> {code:java}
> import org.junit.jupiter.api.Test;
> import java.nio.charset.StandardCharsets;
> public class SurefireLoggingTest {
> private final byte[] aNiceString = "what fun times, standard out is
> broken\n".getBytes(StandardCharsets.US_ASCII);
> @Test
> public void fun() {
> System.out.write(aNiceString, 5, 3);
> }
> @Test
> public void fun_times() {
> System.out.write(aNiceString, 5, 9);
> }
> }
> {code}
>
> Both tests will pass under Intellij, writing "fun" and "fun times" to
> System.out. Whereas, with Surefire capturing standard out when running from
> maven, only fun_times() passes. fun() will fail with:
>
> {noformat}
> java.lang.IndexOutOfBoundsException: off < 0 || len < 0 || off >=
> input.length || len > input.length || off > len{noformat}
>
> If you look at the Javadoc contract for PrintStream.write(byte buf[], int
> off, int len), you can see that len is "Number of bytes to write", so you can
> see that it should be fine to print the substring "fun", of length 3, at
> offset 5. And indeed that is what happens in Intellij.
>
> I suspect that the failing test isolates the problem to when the offset
> "exceeds" the length of the substring. The wrong length is being checked in
> StringUtils.escapeBytesToPrintable(). I think that the check intended to
> ensure the offset didn't exceed the end of the byte array, not the length of
> the slice. But that is already covered by "off >= input.length". So there is
> no benefit to also checking "off > len".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
