michael-o commented on a change in pull request #37: [WAGON-526] making the
retry handle of http client configurable
URL: https://github.com/apache/maven-wagon/pull/37#discussion_r211383488
##########
File path:
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
##########
@@ -354,6 +360,92 @@ private static PoolingHttpClientConnectionManager
createConnManager()
return connManager;
}
+ /**
+ * The type of the retry handler, default to
DefaultHttpRequestRetryHandler.
+ * Values can be default, standard (StandardHttpRequestRetryHandler), or a
fully qualified name class.
+ *
+ * @since 3.2
+ */
+ private static final String RETRY_HANDLER_CLASS =
+ System.getProperty( "maven.wagon.http.retryhandler.class",
"standard" );
+
+ /**
+ * true if it's OK to retry non-idempotent requests that have been sent.
Review comment:
This statement is not true. The original documentation does not say this.
Even the default implementation will stop before this value is read if the
request ist not idempotent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
