[ http://jira.codehaus.org/browse/MECLIPSE-139?page=comments#action_79517 ] 
            
Kenney Westerhof commented on MECLIPSE-139:
-------------------------------------------

I just realized I pretty much did the same work you did, by adding the launch 
stuff (i did it from scratch
so I didn't use your code).


I just applied portions of your patch to improve my solution, but I left out 
some things;

- the forcePomgeneration param (don't do 2 new features in 1 patch - still very 
useful but will be applied for another jira issue).
- the test cases; they didn't match with the current codebase.
- the ability to specify how to handle the java resources. This should be 
handled in a default way.
  right now it's still ignoring (i already fixed the resource copying in 
another way a while back by adding
  excludes for **/*.java). 
  A TODO is to also create an ant buildfile for this (merged with a possible 
other build file to fix
  nested output dirs).
- the AntProjectWriter; i already had that code embedded somewhere. It still 
needs to be refactored out
  but your class was too specific; so i postponed this until a more structured 
way is being implemented.



> Eclipse plugin cannot handle Java source files in resource directories
> ----------------------------------------------------------------------
>
>                 Key: MECLIPSE-139
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-139
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Jochen Kuhnle
>         Assigned To: Kenney Westerhof
>             Fix For: 2.3
>
>         Attachments: MECLIPSE-139-java-resources.patch, 
> MECLIPSE-139-java-resources.patch, MECLIPSE-139-java-resources.patch
>
>
> The eclipse plugin cannot handle Java source files in resource directories: 
> The resulting Eclipse configuration compiles the Java files, so the target 
> directory contains the class files, but not the java sources.
> This is often troublesome in unit tests or when you need to use code 
> templates, because you often get compile errors in the Workbench. The 
> attached plugin allows to handle this situation in the following ways:
> 1. Default behavior: Work just as the plugin did before
> 2. Exclude Java files from resource dirs
> 3. Use an Ant builder to copy Java sources
> As a sideeffect, the patch also extends the handling of custom builders: 
> Instead of just specifying a name, you can also specify the triggers and 
> arguments.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to