[
https://issues.apache.org/jira/browse/MWAR-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662733#comment-16662733
]
Robert Scholte commented on MWAR-371:
-------------------------------------
[~Alf.H] I've had a look at your patch. The provided tests don't cover the
change. When cherry-picking only the changes of {{PathSetTest}}, all tests
still succeed.
Also respect the maven code style which you can find at
https://maven.apache.org/developers/conventions/code.html
If you run {{mvn verify -Prun-its}} the project must still succeed after your
changes.
> Overlays break first-win rule for web resource with target path ending with
> '/'
> -------------------------------------------------------------------------------
>
> Key: MWAR-371
> URL: https://issues.apache.org/jira/browse/MWAR-371
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
> Affects Versions: 2.6
> Reporter: Michal Domagala
> Priority: Minor
> Labels: up-for-grabs
> Attachments: custom-0.0.1-SNAPSHOT.war, mwar371-20180905
>
>
> I have WAR 'generic' containing 2 files: x/a1.txt and x/a2.txt
> I have WAR 'custom' with two source files: src/main/custom/a1.txt and
> src/main/custom/a2.txt and settings:
> {code:xml}
> <artifactId>maven-war-plugin</artifactId>
> <configuration>
> <webResources>
> <webResource>
> <directory>src/main/custom</directory>
> <includes><include>a1.txt</include></includes>
> <targetPath>x/</targetPath>
> </webResource>
> <webResource>
> <directory>src/main/custom</directory>
> <includes><include>a2.txt</include></includes>
> <targetPath>x</targetPath>
> </webResource>
> </webResources>
> </configuration>
> {code}
> Note that *targetPath* is different: *x/* vs *x*
> When I build WAR 'custom'
> Actual: a1.txt is generic, a2.txt is custom
> Expected a1.txt and a2.txt are custom
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
