Tibor17 commented on a change in pull request #196: [SUREFIRE-1585] [WIP]
Resolve missing artifact
URL: https://github.com/apache/maven-surefire/pull/196#discussion_r228045641
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/TestClassPath.java
##########
@@ -69,9 +70,9 @@ void avoidArtifactDuplicates( Set<Artifact>
providerArtifacts )
&& ( classifier1 == null ? classifier2 == null :
classifier1.equals( classifier2 ) ) )
{
it.remove();
- if ( logger.isDebugEnabled() )
+ if ( mojo != null && mojo.getLog().isDebugEnabled() )
Review comment:
I have only several problems with this class:
1. We have AbstractSurefireMojo here.
2. We know what provider is being executed. What about to add a boolean to
this method `isPlatformPrvicer` or enum instead of using null-checks in `if (
junitJupiterApi != null && junitJupiterEngine == null )`.
3. Why we do not align the versions of `junit-platform-launcher` dependency
of our provider in classpath according to user's dependency version as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
