sormuras commented on a change in pull request #196: [SUREFIRE-1585] [WIP] 
Resolve missing and align "JUnit 5" artifacts
URL: https://github.com/apache/maven-surefire/pull/196#discussion_r232469490
 
 

 ##########
 File path: surefire-its/src/test/resources/junit-platform/pom.xml
 ##########
 @@ -70,4 +64,17 @@
             </snapshots>
         </repository>
     </repositories>
+
+    <pluginRepositories>
 
 Review comment:
   In `JUnitPlatformEnginesIT` there's the line 66 with `args.add( new Object[] 
{ "1.4.0-SNAPSHOT", "5.4.0-SNAPSHOT", "1.1.1", "1.0.0" } );` being passed to 
`unpack( "junit-platform",...` within the `@Test platform()` method.
   iirc, the auto-resolve feature didn't work when only a user-defined snapshot 
repo was added to the project.
   
   Just double-checked and now it works. Removing the `<pluginRepositories>` 
element.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to