Tibor17 commented on a change in pull request #196: [SUREFIRE-1585] [WIP]
Resolve missing and align "JUnit 5" artifacts
URL: https://github.com/apache/maven-surefire/pull/196#discussion_r232477337
##########
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
##########
@@ -243,7 +243,7 @@ private StackTraceWriter getStackTraceWriter(
TestIdentifier testIdentifier, Thr
{
String className = getClassName( testIdentifier );
String methodName = getMethodName( testIdentifier ).orElse( "" );
- return new PojoStackTraceWriter( className, methodName, throwable );
+ return new LegacyPojoStackTraceWriter( className, methodName,
throwable );
Review comment:
Yes to restore please. We should use the previous `PojoStackTraceWriter`.
The old `LegacyPojoStackTraceWriter` has bad user experience on the console.
Now it has only one purpose within plugin's process. Maybe it could be moved to
`surefire-common`. We will have a chance to break backwards compatibility in
3.0.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
