jglick commented on a change in pull request #199: Surefire 1593 URL: https://github.com/apache/maven-surefire/pull/199#discussion_r233070329
########## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java ########## @@ -116,10 +116,10 @@ private File createJar( @Nonnull List<String> classPath, @Nonnull String startCl StringBuilder cp = new StringBuilder(); for ( Iterator<String> it = classPath.iterator(); it.hasNext(); ) { - File classPathElement = new File( it.next() ); + String classPathElement = it.next(); String uri = toClasspathElementUri( parent, classPathElement, dumpLogDirectory ); cp.append( uri ); - if ( classPathElement.isDirectory() && !uri.endsWith( "/" ) ) + if ( new File( classPathElement ).isDirectory() && !uri.endsWith( "/" ) ) Review comment: > we should change the method signature No, I deliberately used `String` parameters so as to make it possible to write unit tests. `Path`s can (as far as I know) only be constructed using platform-specific methods, making the tests behave differently according to the machine running them. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services