[
https://issues.apache.org/jira/browse/MRESOLVER-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686854#comment-16686854
]
ASF GitHub Bot commented on MRESOLVER-63:
-----------------------------------------
rfscholte commented on a change in pull request #23: [MRESOLVER-63]
FileTransformer#transformData(File) should also throw TransformException
URL: https://github.com/apache/maven-resolver/pull/23#discussion_r233528693
##########
File path:
maven-resolver-api/src/main/java/org/eclipse/aether/transform/FileTransformer.java
##########
@@ -47,5 +46,5 @@
* @param file the file with the original data
* @return the transformed data
*/
- InputStream transformData( File file ) throws IOException;
+ InputStream transformData( File file ) throws FileTransformationException;
Review comment:
Both IOException and TransformException must be thrown. Better not make it
too explicit, we might do other transformations as well in the future, not only
filebased.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> FileTransformer#transformData(File) should also throw TransformException
> ------------------------------------------------------------------------
>
> Key: MRESOLVER-63
> URL: https://issues.apache.org/jira/browse/MRESOLVER-63
> Project: Maven Resolver
> Issue Type: Improvement
> Components: resolver
> Affects Versions: 1.3.1
> Reporter: Robert Scholte
> Priority: Major
> Labels: up-for-grabs
> Fix For: 1.3.2
>
>
> 1.3.1 introduced the FileTransformer to allow on-the-fly transforming of data.
> For XML files it makes sense to use XMLFilters and create an XMLReader. This
> can throw a SAXException, which is a checked exception, which shouldn't be
> rethrown as an IOException.
> Better to introduce a new Exception to handle this case properly.
> Assuming this class isn't used anywhere yet, it should be good to introduce
> it asap.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
