[
https://issues.apache.org/jira/browse/SUREFIRE-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707875#comment-16707875
]
ASF GitHub Bot commented on SUREFIRE-1602:
------------------------------------------
Tibor17 commented on a change in pull request #205: [SUREFIRE-1602] Surefire
fails loading class ForkedBooter when using a sub-directory pom file and a
local maven repo
URL: https://github.com/apache/maven-surefire/pull/205#discussion_r238452891
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -2369,7 +2369,21 @@ private Artifact getSurefireBooterArtifact()
*/
File getSurefireTempDir()
{
- return IS_OS_WINDOWS ? createSurefireBootDirectoryInTemp() :
createSurefireBootDirectoryInBuild();
+ File result = IS_OS_WINDOWS ? createSurefireBootDirectoryInTemp() :
createSurefireBootDirectoryInBuild();
+ try
+ {
+ File canonical = result.getCanonicalFile();
+ if ( !result.equals( canonical ) )
+ {
+ logger.debug( "Canonicalized tempDir path " + result + " to "
+ canonical );
Review comment:
Let's use simple quotation marks as it is down with IOException which avoids
white spaces:
`logger.debug( "Canonicalized surefire tempDir path '" + result + "' to '" +
canonical + "'." )`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Surefire fails loading class ForkedBooter when using a sub-directory pom file
> and a local maven repo
> ----------------------------------------------------------------------------------------------------
>
> Key: SUREFIRE-1602
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1602
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
> Affects Versions: 3.0.0-M1
> Environment: maven 3.6.0 open-jdk-8 (docker image
> maven:3.6.0-open-jdk-8)
> Reporter: Daniel Kurzynski
> Assignee: Tibor Digana
> Priority: Major
> Fix For: 3.0.0-M2
>
> Attachments: execute_error.txt, execute_ok.txt
>
>
> Steps to reproduce:
> Use a docker image for maven:3.6 (docker run -it maven:3.6.0-jdk-8 bash)
> Inside generate a new project:
> {code:java}
> mvn archetype:generate \
> -DinteractiveMode=false \
> -DarchetypeGroupId=com.sap.cloud.s4hana.archetypes \
> -DarchetypeArtifactId=scp-cf-tomee \
> -DarchetypeVersion=2.7.0 \
> -DgroupId=com.sap.cloud.sdk.tutorial \
> -DartifactId=testapp\
> -Dversion=1.0-SNAPSHOT \
> -Dpackage=com.sap.cloud.s4hana.examples{code}
> In the folder testapp set surefire version to 3.0.0-M1 in unit-tests/pom.xml
> and integration-tests/pom.xml
> Build the project
> {code:java}
> mvn -Dmaven.repo.local=maven_local_repo -Dmaven.test.skip clean install{code}
> Running the tests afterwards will fail
> {code:java}
> mvn test -Dmaven.repo.local=maven_local_repo --file
> ./integration-tests/pom.xml{code}
> The error message in the logs is:
> Error: Could not find or load main class
> org.apache.maven.surefire.booter.ForkedBooter
> However, it only fails when using ./ in the beginning of the file parameter
> in combination with having a local maven repo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
