[
https://issues.apache.org/jira/browse/SUREFIRE-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707026#comment-16707026
]
ASF GitHub Bot commented on SUREFIRE-1602:
------------------------------------------
eolivelli closed pull request #204: [SUREFIRE-1602] Surefire fails loading
class ForkedBooter when using a sub-directory pom file and a local maven repo
URL: https://github.com/apache/maven-surefire/pull/204
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
index 79db5c6f3..03c703162 100644
---
a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
+++
b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
@@ -103,7 +103,7 @@ private File createJar( @Nonnull List<String> classPath,
@Nonnull String startCl
{
file.deleteOnExit();
}
- Path parent = file.getParentFile().toPath();
+ Path parent = file.getParentFile().toPath().normalize();
FileOutputStream fos = new FileOutputStream( file );
try ( JarOutputStream jos = new JarOutputStream( fos ) )
{
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Surefire fails loading class ForkedBooter when using a sub-directory pom file
> and a local maven repo
> ----------------------------------------------------------------------------------------------------
>
> Key: SUREFIRE-1602
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1602
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
> Affects Versions: 3.0.0-M1
> Environment: maven 3.6.0 open-jdk-8 (docker image
> maven:3.6.0-open-jdk-8)
> Reporter: Daniel Kurzynski
> Assignee: Tibor Digana
> Priority: Major
> Fix For: 3.0.0-M2
>
> Attachments: execute_error.txt, execute_ok.txt
>
>
> Steps to reproduce:
> Use a docker image for maven:3.6 (docker run -it maven:3.6.0-jdk-8 bash)
> Inside generate a new project:
> {code:java}
> mvn archetype:generate \
> -DinteractiveMode=false \
> -DarchetypeGroupId=com.sap.cloud.s4hana.archetypes \
> -DarchetypeArtifactId=scp-cf-tomee \
> -DarchetypeVersion=2.7.0 \
> -DgroupId=com.sap.cloud.sdk.tutorial \
> -DartifactId=testapp\
> -Dversion=1.0-SNAPSHOT \
> -Dpackage=com.sap.cloud.s4hana.examples{code}
> In the folder testapp set surefire version to 3.0.0-M1 in unit-tests/pom.xml
> and integration-tests/pom.xml
> Build the project
> {code:java}
> mvn -Dmaven.repo.local=maven_local_repo -Dmaven.test.skip clean install{code}
> Running the tests afterwards will fail
> {code:java}
> mvn test -Dmaven.repo.local=maven_local_repo --file
> ./integration-tests/pom.xml{code}
> The error message in the logs is:
> Error: Could not find or load main class
> org.apache.maven.surefire.booter.ForkedBooter
> However, it only fails when using ./ in the beginning of the file parameter
> in combination with having a local maven repo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
