[
https://issues.apache.org/jira/browse/SUREFIRE-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713945#comment-16713945
]
ASF GitHub Bot commented on SUREFIRE-1602:
------------------------------------------
eolivelli closed pull request #205: [SUREFIRE-1602] Surefire fails loading
class ForkedBooter when using a sub-directory pom file and a local maven repo
URL: https://github.com/apache/maven-surefire/pull/205
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
index b18463eac..304f449f2 100644
---
a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
+++
b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
@@ -2369,7 +2369,21 @@ private Artifact getSurefireBooterArtifact()
*/
File getSurefireTempDir()
{
- return IS_OS_WINDOWS ? createSurefireBootDirectoryInTemp() :
createSurefireBootDirectoryInBuild();
+ File result = IS_OS_WINDOWS ? createSurefireBootDirectoryInTemp() :
createSurefireBootDirectoryInBuild();
+ try
+ {
+ File canonical = result.getCanonicalFile();
+ if ( !result.equals( canonical ) )
+ {
+ logger.debug( "Canonicalized tempDir path '" + result + "' to
'" + canonical + "'" );
+ }
+ return canonical;
+ }
+ catch ( IOException e )
+ {
+ logger.error( "Could not canonicalize tempDir path '" + result +
"'", e );
+ }
+ return result;
}
/**
diff --git
a/surefire-its/src/test/java/org/apache/maven/surefire/its/Surefire1602IT.java
b/surefire-its/src/test/java/org/apache/maven/surefire/its/Surefire1602IT.java
new file mode 100644
index 000000000..d37b10845
--- /dev/null
+++
b/surefire-its/src/test/java/org/apache/maven/surefire/its/Surefire1602IT.java
@@ -0,0 +1,49 @@
+package org.apache.maven.surefire.its;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.surefire.its.fixture.OutputValidator;
+import org.apache.maven.surefire.its.fixture.SurefireJUnit4IntegrationTestCase;
+import org.apache.maven.surefire.its.fixture.SurefireLauncher;
+import org.junit.Test;
+
+/**
+ * Test ability to specify a non canonical path as module root
+ *
+ * @author <a href="mailto:eolive...@apache.org";>Enrico Olivelli</a>
+ */
+public class Surefire1602IT
+ extends SurefireJUnit4IntegrationTestCase
+{
+ @Test
+ public void nonCanonicalPath() throws Exception
+ {
+ SurefireLauncher launcher = unpack( "/surefire-1602" );
+ launcher
+ .executeInstall();
+ launcher
+ .addGoal( "--file" )
+ .addGoal( "./integration-tests/pom.xml" )
+ .executeTest();
+ launcher
+ .getSubProjectValidator( "integration-tests" )
+ .assertTestSuiteResults( 1, 0, 0, 0 );
+ }
+}
diff --git a/surefire-its/src/test/resources/surefire-1602/application/pom.xml
b/surefire-its/src/test/resources/surefire-1602/application/pom.xml
new file mode 100644
index 000000000..d2a9c658b
--- /dev/null
+++ b/surefire-its/src/test/resources/surefire-1602/application/pom.xml
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org</groupId>
+ <artifactId>testapp</artifactId>
+ <version>1.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>testapp-application</artifactId>
+</project>
diff --git
a/surefire-its/src/test/resources/surefire-1602/integration-tests/pom.xml
b/surefire-its/src/test/resources/surefire-1602/integration-tests/pom.xml
new file mode 100644
index 000000000..583b37711
--- /dev/null
+++ b/surefire-its/src/test/resources/surefire-1602/integration-tests/pom.xml
@@ -0,0 +1,39 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org</groupId>
+ <artifactId>testapp</artifactId>
+ <version>1.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>testapp-integration-tests</artifactId>
+
+ <dependencies>
+ <dependency>
+ <groupId>org</groupId>
+ <artifactId>testapp-application</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>4.12</version>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>3.0.0-M2-SNAPSHOT</version>
+ </plugin>
+ </plugins>
+ </build>
+</project>
diff --git
a/surefire-its/src/test/resources/surefire-1602/integration-tests/src/test/java/org/ATest.java
b/surefire-its/src/test/resources/surefire-1602/integration-tests/src/test/java/org/ATest.java
new file mode 100644
index 000000000..a4cc2be4c
--- /dev/null
+++
b/surefire-its/src/test/resources/surefire-1602/integration-tests/src/test/java/org/ATest.java
@@ -0,0 +1,9 @@
+package org;
+
+import org.junit.Test;
+
+public class ATest {
+ @Test
+ public void test() {
+ }
+}
\ No newline at end of file
diff --git a/surefire-its/src/test/resources/surefire-1602/pom.xml
b/surefire-its/src/test/resources/surefire-1602/pom.xml
new file mode 100644
index 000000000..508e99b35
--- /dev/null
+++ b/surefire-its/src/test/resources/surefire-1602/pom.xml
@@ -0,0 +1,18 @@
+<?xml version='1.0' encoding='utf-8'?>
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org</groupId>
+ <artifactId>testapp</artifactId>
+ <version>1.0-SNAPSHOT</version>
+ <packaging>pom</packaging>
+
+ <modules>
+ <module>application</module>
+ <module>unit-tests</module>
+ <module>integration-tests</module>
+ </modules>
+</project>
diff --git a/surefire-its/src/test/resources/surefire-1602/unit-tests/pom.xml
b/surefire-its/src/test/resources/surefire-1602/unit-tests/pom.xml
new file mode 100644
index 000000000..4172dc82a
--- /dev/null
+++ b/surefire-its/src/test/resources/surefire-1602/unit-tests/pom.xml
@@ -0,0 +1,43 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org</groupId>
+ <artifactId>testapp</artifactId>
+ <version>1.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>testapp-unit-tests</artifactId>
+
+ <dependencies>
+ <dependency>
+ <groupId>org</groupId>
+ <artifactId>testapp-application</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>4.12</version>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>3.0.0-M2-SNAPSHOT</version>
+ <configuration>
+ <reuseForks>false</reuseForks>
+ <forkCount>1</forkCount>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+</project>
diff --git
a/surefire-its/src/test/resources/surefire-1602/unit-tests/src/test/java/org/ATest.java
b/surefire-its/src/test/resources/surefire-1602/unit-tests/src/test/java/org/ATest.java
new file mode 100644
index 000000000..a4cc2be4c
--- /dev/null
+++
b/surefire-its/src/test/resources/surefire-1602/unit-tests/src/test/java/org/ATest.java
@@ -0,0 +1,9 @@
+package org;
+
+import org.junit.Test;
+
+public class ATest {
+ @Test
+ public void test() {
+ }
+}
\ No newline at end of file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Surefire fails loading class ForkedBooter when using a sub-directory pom file
> and a local maven repo
> ----------------------------------------------------------------------------------------------------
>
> Key: SUREFIRE-1602
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1602
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
> Affects Versions: 3.0.0-M1
> Environment: maven 3.6.0 open-jdk-8 (docker image
> maven:3.6.0-open-jdk-8)
> Reporter: Daniel Kurzynski
> Assignee: Tibor Digana
> Priority: Major
> Fix For: 3.0.0-M2
>
> Attachments: execute_error.txt, execute_ok.txt
>
>
> Steps to reproduce:
> Use a docker image for maven:3.6 (docker run -it maven:3.6.0-jdk-8 bash)
> Inside generate a new project:
> {code:java}
> mvn archetype:generate \
> -DinteractiveMode=false \
> -DarchetypeGroupId=com.sap.cloud.s4hana.archetypes \
> -DarchetypeArtifactId=scp-cf-tomee \
> -DarchetypeVersion=2.7.0 \
> -DgroupId=com.sap.cloud.sdk.tutorial \
> -DartifactId=testapp\
> -Dversion=1.0-SNAPSHOT \
> -Dpackage=com.sap.cloud.s4hana.examples{code}
> In the folder testapp set surefire version to 3.0.0-M1 in unit-tests/pom.xml
> and integration-tests/pom.xml
> Build the project
> {code:java}
> mvn -Dmaven.repo.local=maven_local_repo -Dmaven.test.skip clean install{code}
> Running the tests afterwards will fail
> {code:java}
> mvn test -Dmaven.repo.local=maven_local_repo --file
> ./integration-tests/pom.xml{code}
> The error message in the logs is:
> Error: Could not find or load main class
> org.apache.maven.surefire.booter.ForkedBooter
> However, it only fails when using ./ in the beginning of the file parameter
> in combination with having a local maven repo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
